Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: Drop v14.x support #25101

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Angular: Drop v14.x support #25101

merged 2 commits into from
Dec 4, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Dec 4, 2023 •
edited
Loading

Closes N/A

What I did

Dropped Angular 14 support in Storybook 8.0

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added maintenance User-facing maintenance tasks angular ci:daily Run the CI jobs that normally run in the daily job. labels Dec 4, 2023
@valentinpalkovic valentinpalkovic self-assigned this Dec 4, 2023
@socket-security Socket Security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@babel/plugin-transform-runtime 7.23.2 None +0 38.7 kB nicolo-ribaudo
@angular/cli 16.2.10...17.0.5 None +38/-29 11.7 MB google-wombot
@angular-devkit/build-angular 16.2.10...17.0.5 network +67/-64 76.2 MB google-wombot
@angular/compiler-cli 16.2.12...17.0.5 None +3/-4 37.4 MB google-wombot
@angular-devkit/architect 0.1600.6...0.1700.5 None +2/-1 511 kB google-wombot
@angular/platform-browser-dynamic 16.2.12...17.0.5 None +6/-6 48.9 MB google-wombot
@angular/core 16.2.12...17.0.5 None +1/-1 25.7 MB google-wombot
@angular/platform-browser 16.2.12...17.0.5 None +4/-4 39.3 MB google-wombot
@angular/common 16.2.12...17.0.5 None +2/-2 36.8 MB google-wombot
@angular/animations 16.2.12...17.0.5 None +2/-2 27.4 MB google-wombot
@angular/forms 16.2.12...17.0.5 None +5/-5 41.2 MB google-wombot
@angular/compiler 16.2.12...17.0.5 None +2/-2 35.2 MB google-wombot
zone.js 0.13.3...0.14.2 None +0/-0 1.95 MB google-wombot
@angular-devkit/core 16.2.10...17.0.5 None +1/-0 346 kB google-wombot

🚮 Removed packages: [email protected]

@socket-security Socket Security
Copy link

socket-security bot commented Dec 4, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], @npmcli/[email protected], [email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:daily Run the CI jobs that normally run in the daily job. labels Dec 4, 2023
@ndelangen
Copy link
Member

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @npmcli/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

@valentinpalkovic valentinpalkovic merged commit 8097dc7 into next Dec 4, 2023
101 of 103 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/drop-angular-14-and-less-support branch December 4, 2023 20:39
@github-actions github-actions bot mentioned this pull request Dec 4, 2023
Merged
36 tasks
@valentinpalkovic valentinpalkovic mentioned this pull request Dec 5, 2023
Closed
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
Closed
44 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 27, 2023 •
edited
Loading

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 35275a9

@valentinpalkovic valentinpalkovic removed the maintenance User-facing maintenance tasks label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@yannbf yannbf Awaiting requested review from yannbf

Assignees

@valentinpalkovic valentinpalkovic

Labels
angular BREAKING CHANGE ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @ndelangen